Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve debug tool performance #158

Merged
merged 7 commits into from
Nov 15, 2024
Merged

fix: improve debug tool performance #158

merged 7 commits into from
Nov 15, 2024

Conversation

mcollovati
Copy link
Contributor

@mcollovati mcollovati commented Nov 14, 2024 •
edited
Loading

Description

Prevents concurrent request to hijack an ongoing serialization job causing timeouts.

Fixes #147

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mcollovati
fix: improve debug tool performance
d7c19ef 
Prevents concurrent request to hijack an ongoing serialization job
causing timeouts.

Related to #147
@mcollovati
format
88a1f50
@mcollovati mcollovati marked this pull request as draft November 14, 2024 10:24
@mcollovati mcollovati mentioned this pull request Nov 14, 2024
Closed
@mcollovati mcollovati marked this pull request as ready for review November 14, 2024 15:12
@mcollovati
Copy link
Contributor Author

Should most likely be back-ported to all maintained branches.

MatthewVaadin
MatthewVaadin approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@MatthewVaadin MatthewVaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work finding this performance improvement!

@MatthewVaadin MatthewVaadin merged commit 31c2a13 into main Nov 15, 2024
2 checks passed
@MatthewVaadin MatthewVaadin deleted the fix/improve-debut-tool-performance branch November 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewVaadin MatthewVaadin MatthewVaadin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

session serialization debug can get very slow
2 participants
@mcollovati @MatthewVaadin