fix: fix session serialization for PUSH with websocket #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PUSH transport is websocket, the request associate to atmosphere is a stub implementation that always return false for 'isRequestedSessionIdValid()' preventing PushSessionTracker to serialize the session. In addition, accessing the request from a background thread may throw IllegalStateException if the servlet container is recycling request objects (e.g. Tomcat facade). With this change, the session validiy is checked against the SessionListener that is already observing session lifecycle events. Fixes #119
tamasmak
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When PUSH transport is websocket, the request associated to atmosphere is a stub implementation that always returns false for 'isRequestedSessionIdValid()' preventing PushSessionTracker to serialize the session.
In addition, accessing the request from a background thread may throw IllegalStateException if the servlet container is recycling request objects (e.g. Tomcat facade). With this change, the session validity is checked against the SessionListener that is already observing session lifecycle events.
Fixes #119
Type of change
Checklist
Additional for
Featuretype of change