fix: check every module when looking if a file is inside the project #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Artifact build on last commit: distributions.zip. |
| * project base folders. For the main project, the base directory is the project root and the module name is | ||
| * "base-module". | ||
| */ | ||
| fun getBaseDirectoriesForProject(project: Project): Map<String, List<String>> { |
There was a problem hiding this comment.
Uses same code as in GetModulePathsHandler, might be somehow unified.
| @@ -45,7 +46,9 @@ abstract class AbstractHandler(val project: Project) : Handler { | |||
| fun isFileInsideProject(project: Project, file: File): Boolean { | |||
| if (file.exists()) { | |||
| val path = file.toPath() | |||
| return path.toRealPath().startsWith(project.basePath!!) | |||
There was a problem hiding this comment.
Can you try if changing to project.guessProjectDir() changes anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To check if a file was inside the project we were only checking the project base folder which is not accurate when the project has external modules.
The fix looks in every module in the project including the base project.
Fixes #163
Type of change
Checklist
Additional for
Featuretype of change