fix: CopilotUndoManager service for tracking actions on save #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Artifact build on last commit: distributions.zip. |
MarcinVaadin
commented
Oct 15, 2024
| @@ -19,10 +19,10 @@ jobs: | |||
| java-version: '21' | |||
| distribution: 'temurin' | |||
| cache: gradle | |||
| - name: Setup Gradle | |||
| uses: gradle/actions/setup-gradle@v3 | |||
There was a problem hiding this comment.
Removed because we want to use embedded gradle wrapper
MarcinVaadin
commented
Oct 15, 2024
| } | ||
| } | ||
| return RESPONSE_OK | ||
| override fun after(vfsFile: VirtualFile) { |
There was a problem hiding this comment.
Do not open in editor binary files as it is only for text documents.
mgarciavaadin
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use approach similar to VS Code plugin to track file changes in our own service. Assumed that file writes that happen after given time window are invoked by IDE as save actions. Window size set to 1000 ms.
Fixes: https://github.com/vaadin/copilot-internal/issues/3305