fix(file-router): get back Flow AutoLayout

[Lodin]

Fixes #2928

[codecov]

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.79%. Comparing base (e51780a) to head (fc63e61).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../generator-utils/src/dependencies/ImportManager.ts	16.66%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
- Coverage   92.89%   92.79%   -0.10%     
==========================================
  Files          83       84       +1     
  Lines        3137     3149      +12     
  Branches      757      759       +2     
==========================================
+ Hits         2914     2922       +8     
- Misses        171      175       +4     
  Partials       52       52              

Flag	Coverage Δ
unittests	92.79% <88.09%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[caalador]

Now there is at least the issue that in file-routes.ts the flowLayout is moved from a boolean property in createRoute to be a config parameter.
This has the issue that when creating the file-routes.ts we do not have the actual config from the tsx file available and the marking is done according to the available layouts.
This is remediesd in createViewConfigJson where the file-routes.ts flowLayout was set if config.flowLayout === null | undefined, but now it is always set so we do not set it to the user defined value at all.
So now if you have a @Layout("/") RouterLayout and have a hilla view with the configuration flowLayout: false it will still be shown in the layout as the file-routes definition overrides any user definitions.

[caalador]

I also get the exception

2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :  ERROR(TypeScript)  An import path can only end with a '.tsx' extension when 'allowImportingTsExtensions' is enabled.
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :  FILE  C:/Users/mgran/Code/Vaadin/flow-hilla-hybrid-example/src/main/frontend/generated/file-routes.ts:6:25
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : 
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     4 | import * as Page_2 from "../views/about.tsx";
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     5 | import * as Page_3 from "../views/hilla.tsx";
2024-11-27T13:46:11.473+02:00  INFO 27456 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :   > 6 | import * as Page_4 from "../views/login.tsx";

Which is fixed by removing the extension from the imports, but as this is a generated file it is a bit strange to get an exception.

[Lodin]

@caalador, thanks for the review.

So now if you have a @layout("/") RouterLayout and have a hilla view with the configuration flowLayout: false it will still be shown in the layout as the file-routes definition overrides any user definitions.

Oh, thanks! I definitely need a test for that...

I also get the exception

That's a bug, sorry. Already fixed 😅

P.S. Don't hesitate to use Request Changes to block the PR until everything is fixed 😊

[Lodin]

@caalador, does the latest update fix the issue with config overriding you mentioned?

[caalador]

The layouts seem to work as expected (unless I forgot some combination as there are many), but now the imports get this strange full path in the middle and do not work 😓

2024-11-27T14:13:49.665+02:00  INFO 21092 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :  ERROR(TypeScript)  Cannot find module '../C:\Users\mgran\Code\Vaadin\flow-hilla-hybrid-example\src\main\frontend\views/login.js' or its corresponding type declarations.
2024-11-27T14:13:49.665+02:00  INFO 21092 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :  FILE  C:/Users/mgran/Code/Vaadin/flow-hilla-hybrid-example/src/main/frontend/generated/file-routes.ts:6:25
2024-11-27T14:13:49.665+02:00  INFO 21092 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   : 
2024-11-27T14:13:49.665+02:00  INFO 21092 --- [v-server-output] c.v.b.devserver.DevServerOutputTracker   :     4 | import * as Page_2 from "../C:\\Users\\mgran\\Code\\Vaadin\\flow-hilla-hybrid-example\\src\\main\\frontend\\views/about.js";

[Lodin]

That darn windows paths... 🥲 Let me fix it

[caalador]

That darn windows paths... 🥲 Let me fix it

That's the reason why I've taken on the burden of a windows machine for development

[sonarcloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Lodin]

@caalador, what about now? I hope it works...

[caalador]

Now it seems to work correctly. 👍

[Lodin]

Great! Could you approve it, so we can merge it?