Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add web-test-runner for react-auth #2926

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Nov 26, 2024

Fixes test failures in #2901 by replacing Karma Test Runner (deprecated) with Web Test Runner.

Web Test Runner is applied only to the react-auth package. The plan is to incrementally transfer other browser-based packages over time.

@Lodin Lodin requested a review from platosha November 26, 2024 19:11
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Lodin
Copy link
Contributor Author

Lodin commented Nov 26, 2024

Please ignore SonarCloud results. The code duplication is expected because there is some files moved out of karma.config.js and placed in TypeScript files. Since Karma is unable to work with TS, I had to keep both versions. When we move to WTR completely, the duplication will be gone.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (e2af537) to head (c1161f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2926      +/-   ##
==========================================
+ Coverage   92.64%   92.89%   +0.24%     
==========================================
  Files          83       83              
  Lines        2857     3137     +280     
  Branches      744      757      +13     
==========================================
+ Hits         2647     2914     +267     
- Misses        157      171      +14     
+ Partials       53       52       -1     
Flag Coverage Δ
unittests 92.89% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@platosha platosha merged commit e51780a into main Nov 27, 2024
14 of 15 checks passed
@platosha platosha deleted the chore/react-auth-wtr branch November 27, 2024 10:35
cromoteca pushed a commit that referenced this pull request Nov 27, 2024
* chore: add web-test-runner for react-auth

* chore: fix package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants