Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-router): add skipLayouts feature #2915

Merged
merged 11 commits into from
Nov 22, 2024
Merged

feat(file-router): add skipLayouts feature #2915

merged 11 commits into from
Nov 22, 2024

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Nov 20, 2024

Resolves #2385.

@Lodin Lodin added the hilla Issues related to Hilla label Nov 20, 2024
@Lodin Lodin requested a review from platosha November 20, 2024 16:00
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.70%. Comparing base (674b31b) to head (114872e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e-router/src/runtime/RouterConfigurationBuilder.ts 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
+ Coverage   92.64%   92.70%   +0.05%     
==========================================
  Files          83       83              
  Lines        2842     2851       +9     
  Branches      739      739              
==========================================
+ Hits         2633     2643      +10     
+ Misses        158      157       -1     
  Partials       51       51              
Flag Coverage Δ
unittests 92.70% <96.77%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 21, 2024

@platosha platosha merged commit f9ad9dd into main Nov 22, 2024
15 checks passed
@platosha platosha deleted the feat/skip-layouts branch November 22, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature for rendering an FS router view outside the main layout
2 participants