Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for java8 date time in signals #2899

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Nov 8, 2024

Description

This introduces endpointObjectMapper bean to be used in both the EndpointInvoker and in the Signals library.
If the user overrides the JacksonObjectMapperFactory by the EndpointController.ENDPOINT_MAPPER_FACTORY_BEAN_QUALIFIER qualifier, it also by default affects the the object mapper in the signals library.

Fixes #2891

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (1636cb7) to head (da2d444).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2899   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files          83       83           
  Lines        2851     2851           
  Branches      739      739           
=======================================
  Hits         2643     2643           
  Misses        157      157           
  Partials       51       51           
Flag Coverage Δ
unittests 92.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@taefi taefi marked this pull request as ready for review November 9, 2024 00:36
@cromoteca cromoteca self-requested a review November 22, 2024 14:21
Copy link

sonarcloud bot commented Nov 22, 2024

* @param mapper
* the object mapper to be used in Signals
*/
public static void setMapper(ObjectMapper mapper) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it dangerous to define a public api to set the mapper? Can package-level be enough for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not all of the test classes in the same package. And, I'm not sure whether we can impose such a limitation to user codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListSignal with Java 8 date/time types fail with Jackson ObjectMapper
3 participants