-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for java8 date time in signals #2899
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
=======================================
Coverage 92.70% 92.70%
=======================================
Files 83 83
Lines 2851 2851
Branches 739 739
=======================================
Hits 2643 2643
Misses 157 157
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Quality Gate passedIssues Measures |
* @param mapper | ||
* the object mapper to be used in Signals | ||
*/ | ||
public static void setMapper(ObjectMapper mapper) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it dangerous to define a public api to set the mapper? Can package-level be enough for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, not all of the test classes in the same package. And, I'm not sure whether we can impose such a limitation to user codes.
Description
This introduces
endpointObjectMapper
bean to be used in both theEndpointInvoker
and in the Signals library.If the user overrides the
JacksonObjectMapperFactory
by theEndpointController.ENDPOINT_MAPPER_FACTORY_BEAN_QUALIFIER
qualifier, it also by default affects the the object mapper in the signals library.Fixes #2891
Type of change
Checklist