Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable signals to have fine-grained validations #2888

Merged
merged 44 commits into from
Nov 20, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Nov 4, 2024

Description

This adds the API for adding fine-grained validators for different signal operations.
Fixes #2835

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@taefi taefi changed the title Collab/signal validators feat: enable signals to have fine-grained validations Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (0a9bd31) to head (8abec4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2888   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files          83       83           
  Lines        2842     2842           
  Branches      739      739           
=======================================
  Hits         2633     2633           
  Misses        158      158           
  Partials       51       51           
Flag Coverage Δ
unittests 92.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@taefi taefi marked this pull request as ready for review November 6, 2024 23:40
Copy link

sonarcloud bot commented Nov 19, 2024

@platosha platosha merged commit c67eac4 into main Nov 20, 2024
15 checks passed
@platosha platosha deleted the collab/signal-validators branch November 20, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable fine-grained access control for full-stack signals
3 participants