Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix log message in Hotswapper #2677

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Conversation

mcollovati
Copy link
Contributor

Description

Fixes the Hotswapper log message to print the changed class instead of listing all the classes referenced by endpoints.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Fixes the Hotswapper log message to print the changed class instead of
listing all the classes referenced by endpoints.
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (45a53d9) to head (0cb6eb2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2677   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files          76       76           
  Lines        2477     2477           
  Branches      643      643           
=======================================
  Hits         2286     2286           
  Misses        144      144           
  Partials       47       47           
Flag Coverage Δ
unittests 92.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and probably doesn't need adding tests.

Copy link

sonarcloud bot commented Aug 29, 2024

@taefi taefi merged commit ecff974 into main Aug 29, 2024
15 checks passed
@taefi taefi deleted the chore/fix-hotswapper-log-message branch August 29, 2024 10:03
vaadin-bot pushed a commit that referenced this pull request Aug 29, 2024
Fixes the Hotswapper log message to print the changed class instead of
listing all the classes referenced by endpoints.

Co-authored-by: Soroosh Taefi <[email protected]>
taefi added a commit that referenced this pull request Aug 29, 2024
chore: fix log message in Hotswapper (#2677)

Fixes the Hotswapper log message to print the changed class instead of
listing all the classes referenced by endpoints.

Co-authored-by: Marco Collovati <[email protected]>
Co-authored-by: Soroosh Taefi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants