Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Atmosphere to resolve problems in servlets with multiple mappings #8785

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Mar 8, 2017

Fixes #8734


This change is Reviewable

@hesara
Copy link
Contributor

hesara commented Mar 9, 2017

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


pom.xml, line 37 at r1 (raw file):

        <vaadin.sass.version>0.9.13</vaadin.sass.version>
        <!-- Note that this should be kept in sync with the class Constants -->
        <atmosphere.runtime.version>2.4.5.vaadin2</atmosphere.runtime.version>

version not in Maven Central, and I didn't see any recent builds for it on r2d2 either - ok to submit this change once the version is available


Comments from Reviewable

@Artur-
Copy link
Member Author

Artur- commented Mar 9, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


pom.xml, line 37 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…

version not in Maven Central, and I didn't see any recent builds for it on r2d2 either - ok to submit this change once the version is available

vaadin/atmosphere#1


Comments from Reviewable

@Artur- Artur- merged commit 7226e1a into vaadin:master Mar 9, 2017
@Artur- Artur- deleted the _new-atmosphere branch March 9, 2017 18:24
@Artur- Artur- restored the _new-atmosphere branch March 9, 2017 18:24
@pleku pleku added this to the 8.0.3 milestone Mar 9, 2017
elmot pushed a commit that referenced this pull request Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants