Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix outdated AppShell javadoc #9453

Merged
merged 1 commit into from
Nov 20, 2020
Merged

chore: fix outdated AppShell javadoc #9453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flow-server/src/main/java/com/vaadin/flow/component/page/AppShellConfigurator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
* @BodySize(height = "100vh", width = "100vw")
* @PageTitle("my-title")
* CPush(value = PushMode.AUTOMATIC, transport = Transport.WEBSOCKET_XHR)
* public class AppShell implements VaadinAppShell {
* public class AppShell implements AppShellConfigurator {
* }
* </code>
*
Expand Down
2 changes: 1 addition & 1 deletion flow-server/src/main/java/com/vaadin/flow/server/AppShellRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public void reset() {
* null to reset the previous one when reusing the instance.
*
* @param shell
* the class extending VaadinAppShell class.
* the class implementing AppShellConfigurator.
*/
public void setShell(Class<? extends AppShellConfigurator> shell) {
if (this.appShellClass != null && shell != null) {
Expand Down
2 changes: 1 addition & 1 deletion flow-server/src/main/java/com/vaadin/flow/server/startup/VaadinAppShellInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public static void init(Set<Class<?>> classes, ServletContext context,
List<String> offendingAnnotations = new ArrayList<>();

classes.stream()
// sort classes by putting VaadinAppShell in first position
// sort classes by putting the app shell in first position
.sorted((a, b) -> registry.isShell(a) ? -1
: registry.isShell(b) ? 1 : 0)
.forEach(clz -> {
Expand Down