Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update javadoc of rerouteTo()/forwardTo() #9060

Conversation

mvysny
Copy link
Member

@mvysny mvysny commented Sep 24, 2020

Update javadoc of rerouteTo()/forwardTo() to clear out the difference between the two

@mvysny
Copy link
Member Author

mvysny commented Sep 24, 2020

Copy link
Contributor

@bogdanudrescu bogdanudrescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice update, thank you!

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 2 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. INFO BeforeEvent.java#L570: Do not forget to remove this deprecated code someday. rule
  2. INFO BeforeEvent.java#L633: Do not forget to remove this deprecated code someday. rule

@bogdanudrescu bogdanudrescu merged commit 66475ba into master Sep 30, 2020
@bogdanudrescu bogdanudrescu deleted the enhancement/explain-difference-between-rerouteto-and-forwardto branch September 30, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants