Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for event listeners in template elements #884

Merged
merged 2 commits into from
May 31, 2016
Merged

Add support for event listeners in template elements #884

merged 2 commits into from
May 31, 2016

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented May 30, 2016 •
edited by denis-anisimov
Loading

This change is Reviewable

@Artur-
Add support for overriding template element properties.
7d80454 
Store all not bound properties inside override node. Delegate all
regular properties related method calls to override node.
Doesn't contain client side changes.
@pleku
Copy link
Contributor

pleku commented May 31, 2016

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):
Is there or will there be a tutorial on this, mayhaps tutorial-template-event-handlers.asciidoc should be updated to show case that event handlers via java work

a discussion (no related file):
Is there a demo that showcases this feature ?

Comments from Reviewable

@denis-anisimov
Copy link
Contributor

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

@Artur- Artur- force-pushed the template-element-event-listner branch from 5b4ac76 to 906c9ac Compare May 31, 2016 07:02
@Artur-
Copy link
Member Author

Artur- commented May 31, 2016

Review status: 3 of 11 files reviewed at latest revision, 2 unresolved discussions.

a discussion (no related file):

Previously, pleku (Pekka Hyvönen) wrote…

Is there or will there be a tutorial on this, mayhaps tutorial-template-event-handlers.asciidoc should be updated to show case that event handlers via java work

Updated in https://reviewable.io/reviews/vaadin/hummingbird/887 because it requires support for synchronized properties also

a discussion (no related file):

Previously, pleku (Pekka Hyvönen) wrote…

Is there a demo that showcases this feature ?

https://github.com/vaadin/flow-demo/issues/116 should demo it

Comments from Reviewable

@pleku
Copy link
Contributor

pleku commented May 31, 2016

Reviewed 8 of 8 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@Artur- Artur- merged commit 1065cdd into master May 31, 2016
@Artur- Artur- deleted the template-element-event-listner branch May 31, 2016 07:37
@Artur- Artur- modified the milestone: 0.0.8 May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Artur- Artur-

Labels
None yet
Projects
None yet
Milestone
0.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Artur- @pleku @denis-anisimov