Fix race condition in embedding tests #8507
Conversation
| // attached #8329 | ||
| this.waitUntil((driver) -> Boolean.TRUE | ||
| .equals(this.getCommandExecutor().executeScript( | ||
| "return Array.from(document.getElementsByTagName('*')).some(x => x.shadowRoot !== null)"))); |
There was a problem hiding this comment.
x => x.shadowRoot
That didn't work in IE.
Though we don't run our tests in IE but still : is it possible to write this somehow cross-browser ?
There was a problem hiding this comment.
No, sorry, I meant x.shadowRoot .
I don't know actually what's the output of the compiled production client side code.
But for the previous releases production code produced a code which worked in browsers which don't support web components at all .
In those browsers shadowRoot just don't exist at all.
E.g. in IE11 (again: I don't know which browsers we support nowadays) TB has a specific code which checks the element directly in the parent and then tries to use shadowRoot.
And IE11 of course doesn't support =>.
There was a problem hiding this comment.
I opened the test view in IE8, and the embedded web components just appear as empty tags in the DOM. I don't know if the test is designed to work in IE at all?
There was a problem hiding this comment.
IE 8 ?
IE 8 is not supported for sure.
IE 11 : I don't know.
But yeah, may be it has no sense to care about this at the moment.
denis-anisimov
deleted the
joheriks/8329-fix-race-condition-in-embedding-tests
branch
Fixes #8329. With Chrome dropping native HTML imports and the compatibility mode test for embedded webcomponents relying on polyfill, a race condition had appeared where the shadowroot was not yet attached during test run. Now waits for at least one shadowroot before commencing the test.
Update: should squash when merging.