Updates all components to stable version #4578
Conversation
There was a problem hiding this comment.
Reviewed 99 of 99 files at r1.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained
flow-components-parent/flow-generated-components/src/main/java/com/vaadin/flow/component/button/GeneratedVaadinButton.java, line 202 at r1 (raw file):
} protected void updateStyles() {
Is it ok that we have some methods disappearing from our Java API?
flow-components-parent/flow-generated-components/src/main/java/com/vaadin/flow/component/combobox/GeneratedVaadinComboBoxDropdown.java, line 252 at r1 (raw file):
* @return a {@link Registration} for removing the event listener */ protected Registration addOpenedChangeListener(
This looks even more dangerous then updateStyles disappearance.
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained
flow-components-parent/flow-generated-components/src/main/java/com/vaadin/flow/component/button/GeneratedVaadinButton.java, line 202 at r1 (raw file):
Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
Is it ok that we have some methods disappearing from our Java API?
OK since it is protected but according to semver this is a breaking change and thus warrants a new major version of the component (protected Java API is public user facing API).
Since it is the generated class, we could have claimed that using these methods is not
flow-components-parent/flow-generated-components/src/main/java/com/vaadin/flow/component/combobox/GeneratedVaadinComboBoxDropdown.java, line 252 at r1 (raw file):
Previously, SomeoneToIgnore (Kirill Bulatov) wrote…
This looks even more dangerous then
updateStylesdisappearance.
Again - breaking change.
Should ask the components team on why (?) and how they make this change between beta and final ?
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained
flow-components-parent/flow-generated-components/src/main/java/com/vaadin/flow/component/button/GeneratedVaadinButton.java, line 202 at r1 (raw file):
Previously, pleku (Pekka Hyvönen) wrote…
OK since it is protected but according to semver this is a breaking change and thus warrants a new major version of the component (
protectedJava API is public user facing API).Since it is the generated class, we could have claimed that using these methods is not
This a polymer method that we are not using - and neither should be anyone else. I'd say it should have been excluded from the generator anyway, but now it has been here until this point, which is unfortunate.
The usage of generated classes is still perceived to be "at your own risk" and the generator template should be updated to refrain that in the class level javadocs.
I'm going to let this change slide in this minor.
flow-components-parent/flow-generated-components/src/main/java/com/vaadin/flow/component/combobox/GeneratedVaadinComboBoxDropdown.java, line 252 at r1 (raw file):
Previously, pleku (Pekka Hyvönen) wrote…
Again - breaking change.
Should ask the components team on why (?) and how they make this change between beta and final ?
This is actually cb-dropdown, and not used anywhere.
There was a problem hiding this comment.
Reviewable status: 3 unresolved discussions, 0 of 1 LGTMs obtained
a discussion (no related file):
Blocking this for now, pending inclusion decision for certain 1.1 version
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained
flow-components-parent/flow-generated-components/src/main/java/com/vaadin/flow/component/button/GeneratedVaadinButton.java, line 202 at r1 (raw file):
Previously, pleku (Pekka Hyvönen) wrote…
This a polymer method that we are not using - and neither should be anyone else. I'd say it should have been excluded from the generator anyway, but now it has been here until this point, which is unfortunate.
The usage of generated classes is still perceived to be "at your own risk" and the generator template should be updated to refrain that in the class level javadocs.
I'm going to let this change slide in this minor.
Ok.
flow-components-parent/flow-generated-components/src/main/java/com/vaadin/flow/component/combobox/GeneratedVaadinComboBoxDropdown.java, line 252 at r1 (raw file):
Previously, pleku (Pekka Hyvönen) wrote…
This is actually cb-dropdown, and not used anywhere.
Ok.
There was a problem hiding this comment.
Reviewed 19 of 19 files at r2.
Reviewable status: 1 unresolved discussion, 0 of 1 LGTMs obtained, and 1 stale
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, 1 of 1 LGTMs obtained, and 1 stale
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, 2 of 1 LGTMs obtained
This is part of the component update. vaadin/flow-component-base#77
This change is