Fix FlowComponentRenderer._clear() for some browsers (#4460) #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix FlowComponentRenderer._clear() for some browsers Fix vaadin-grid-flow#274 The previous implementation works with Chrome, but causes client-side exceptions for Firefox and Edge at least when filtering a Grid that uses ComponentRenderer.
denis-anisimov
approved these changes
Aug 2, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FlowComponentRenderer._clear() for some browsers
Fix vaadin-grid-flow#274
The previous implementation works with Chrome, but causes client-side
exceptions for Firefox and Edge at least when filtering a Grid that
uses ComponentRenderer.
This change is