Add time-picker and generate the code #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZheSun88
commented
Jul 30, 2018
There was a problem hiding this comment.
There is a bug in the generator, #4453
As the bug code is only in the GeneratedVaadinTimePickerTextField.java which doesn't affect the TimePicker. the code has been pushed, so that it will not blocking the implementation of the component
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained
denis-anisimov
approved these changes
Jul 30, 2018
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all discussions resolved, 0 of 1 LGTMs obtained, and 1 stale
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partly related to the vaadin/vaadin-time-picker-flow#1
This change is