-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the test to check the added variant #4418
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,24 @@ | |
public abstract class ComponentDemoTest extends ChromeBrowserTest { | ||
protected WebElement layout; | ||
|
||
/** | ||
* Default variant producer | ||
* <p> | ||
* With current design, the theme variant can be obtained from the button | ||
* attached to the demo | ||
*/ | ||
public static class DefaultProducer | ||
implements Function<WebElement, String> { | ||
|
||
@Override | ||
public String apply(WebElement button) { | ||
String[] variant = button.getText().split("'"); | ||
return variant[1]; | ||
} | ||
} | ||
|
||
private Function<WebElement, String> DEFAULT_VARIANT_PRODUCER = new DefaultProducer(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
@Override | ||
protected int getDeploymentPort() { | ||
return 9998; | ||
|
@@ -56,31 +74,43 @@ public void openDemoPageAndCheckForErrors() { | |
} | ||
|
||
/** | ||
* Verifies variants functionality for the current layout. | ||
* | ||
* Verifies variants functionality for the current layout with using the | ||
* {@link DefaultProducer}. | ||
* <p> | ||
* The test will fail if a specific variant demo is not added first with | ||
* {@link DemoView#addVariantsDemo(Supplier, BiConsumer, BiConsumer, Function, Enum[])} | ||
* method. | ||
*/ | ||
protected void verifyThemeVariantsBeingToggled() { | ||
verifyThemeVariantsBeingToggled(DEFAULT_VARIANT_PRODUCER); | ||
} | ||
|
||
/** | ||
* Verifies variants functionality for the current layout with customized | ||
* variant producer implementation. | ||
*/ | ||
protected void verifyThemeVariantsBeingToggled( | ||
Function<WebElement, String> variantProducer) { | ||
List<WebElement> toggleThemeButtons = layout | ||
.findElement(By.id(VARIANT_TOGGLE_BUTTONS_DIV_ID)) | ||
.findElements(By.tagName("button")); | ||
Assert.assertFalse( | ||
"Expected at least one toggle theme button in 'buttonDiv', but got none", | ||
toggleThemeButtons.isEmpty()); | ||
toggleThemeButtons.forEach(button -> toggleVariantAndCheck( | ||
layout.findElement(By.id(COMPONENT_WITH_VARIANTS_ID)), button)); | ||
layout.findElement(By.id(COMPONENT_WITH_VARIANTS_ID)), button, | ||
variantProducer)); | ||
} | ||
|
||
private void toggleVariantAndCheck(WebElement component, | ||
WebElement button) { | ||
private void toggleVariantAndCheck(WebElement component, WebElement button, | ||
Function<WebElement, String> variantProducer) { | ||
List<String> initialButtonThemes = getComponentThemes(component); | ||
String initialButtonText = button.getText(); | ||
|
||
button.click(); | ||
verifyThemeIsToggled(getComponentThemes(component), button.getText(), | ||
initialButtonThemes, initialButtonText); | ||
initialButtonThemes, initialButtonText, | ||
variantProducer.apply(button)); | ||
|
||
button.click(); | ||
Assert.assertEquals( | ||
|
@@ -100,7 +130,7 @@ private void toggleVariantAndCheck(WebElement component, | |
|
||
private void verifyThemeIsToggled(List<String> updatedThemes, | ||
String updatedButtonText, List<String> previousThemes, | ||
String previousButtonText) { | ||
String previousButtonText, String variantName) { | ||
Assert.assertNotEquals("Button should change its text after toggling", | ||
previousButtonText, updatedButtonText); | ||
|
||
|
@@ -115,6 +145,10 @@ private void verifyThemeIsToggled(List<String> updatedThemes, | |
Assert.assertTrue( | ||
"When a theme variant got added, component 'theme' attribute should contain all previous theme variants", | ||
updatedThemes.containsAll(previousThemes)); | ||
|
||
Assert.assertTrue("The selected theme variant:" + variantName | ||
+ " should be added to the component 'theme' attribute.", | ||
updatedThemes.contains(variantName)); | ||
} else { | ||
Assert.assertTrue( | ||
"When a theme variant got removed, toggle button text should start with 'Add' word", | ||
|
@@ -125,6 +159,9 @@ private void verifyThemeIsToggled(List<String> updatedThemes, | |
Assert.assertTrue( | ||
"When a theme variant got removed, previous theme variants should contain all theme variants from component 'theme' attribute", | ||
previousThemes.containsAll(updatedThemes)); | ||
Assert.assertFalse("The selected theme variant:" + variantName | ||
+ " should be removed from the component 'theme' attribute.", | ||
updatedThemes.contains(variantName)); | ||
} | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First sentence of Javadoc is incomplete (period is missing) or not present.