Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude project maven dependencies from isolated class loader (#20523) (CP: 24.4) #20530

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

…20523)

If the user project directly or transitively depends on maven artifacts,
mojos can fail at runtime because of Maven API loaded from both isolated
class loader and maven.api realm.
This change prevents maven artifacts from being added to the isolated class loader.
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) November 21, 2024 10:21
Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

Test Results

1 119 files  ± 0  1 119 suites  ±0   1h 20m 44s ⏱️ - 1m 11s
7 093 tests ± 0  7 044 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 450 runs   - 20  7 389 ✅  - 20  61 💤 ±0  0 ❌ ±0 

Results for commit e606e44. ± Comparison against base commit a9819c2.

@vaadin-bot vaadin-bot merged commit a0938a3 into 24.4 Nov 21, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20523-to-24.4-1732184047295 branch November 21, 2024 10:31
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants