Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate PWA icons at build time #20516

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

mcollovati
Copy link
Collaborator

@mcollovati mcollovati commented Nov 19, 2024

Description

Generates PWA icons during the production build, preventing the need to use AWT APIs at runtime and making first requests to the application faster. Also prevents potential issues caused by loading AWT native library in native images.
If the base icon cannot be found at build time, Flow will attempt to generate the icons at runtime, exactly how it does before this change.

Fixes #19497

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Generates PWA icons during the production build, preventing the need to use
AWT APIs at runtime and making first requests to the application faster.
Also prevents potential issues caused by loading AWT native library in
native images.

Fixes #19497
Copy link

github-actions bot commented Nov 19, 2024

Test Results

1 157 files  + 1  1 157 suites  +1   1h 34m 44s ⏱️ + 2m 16s
7 506 tests + 5  7 453 ✅ + 5  53 💤 ±0  0 ❌ ±0 
7 825 runs   - 38  7 762 ✅  - 38  63 💤 ±0  0 ❌ ±0 

Results for commit 8a2faa3. ± Comparison against base commit bd8c796.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 20, 2024

@caalador caalador merged commit 9e80eb8 into main Nov 20, 2024
26 checks passed
@caalador caalador deleted the issues/19497-pwa-icons-build-time branch November 20, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hilla app with @PWA annotation fails when running as native compiled image on macOS
3 participants