Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dashboard component feature flag #20508

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ugur-vaadin
Copy link
Contributor

Description

This PR adds the feature flag for the new Dashboard component.

Related issue

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

sonarcloud bot commented Nov 19, 2024

Copy link

Test Results

1 156 files  ±0  1 156 suites  ±0   1h 32m 53s ⏱️ -45s
7 498 tests ±0  7 445 ✅ ±0  53 💤 ±0  0 ❌ ±0 
7 823 runs  +5  7 762 ✅ +7  61 💤  - 2  0 ❌ ±0 

Results for commit 1f297e2. ± Comparison against base commit 7ba0f02.

@mshabarov mshabarov merged commit 0a23c61 into main Nov 19, 2024
25 of 26 checks passed
@mshabarov mshabarov deleted the feat-add-dashboard-component-feature-flag branch November 19, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants