Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: move blocking calls outside session lock (#19938) #20475

Merged
merged 10 commits into from
Nov 19, 2024
Merged

Fix: move blocking calls outside session lock (#19938) #20475

merged 10 commits into from
Nov 19, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Nov 14, 2024

No description provided.

@tepi tepi marked this pull request as draft November 14, 2024 14:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

Test Results

1 156 files  ± 0  1 156 suites  ±0   1h 33m 41s ⏱️ +3s
7 498 tests ± 0  7 445 ✅ ± 0  53 💤 ±0  0 ❌ ±0 
7 850 runs  +32  7 789 ✅ +34  61 💤  - 2  0 ❌ ±0 

Results for commit 53e241f. ± Comparison against base commit 7ba0f02.

♻️ This comment has been updated with latest results.

@vaadin-bot vaadin-bot added +0.1.0 and removed +1.0.0 labels Nov 15, 2024
@tepi tepi marked this pull request as ready for review November 15, 2024 10:52
@tepi tepi force-pushed the fix/move-blocking-calls-outside-session-lock branch from 14b2148 to b65e171 Compare November 15, 2024 11:11
mcollovati
mcollovati requested changes Nov 15, 2024
View reviewed changes
flow-server/src/main/java/com/vaadin/flow/server/SynchronizedRequestHandler.java Outdated Show resolved Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/SynchronizedRequestHandler.java Show resolved Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/SynchronizedRequestHandler.java Show resolved Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/SynchronizedRequestHandler.java Outdated Show resolved Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/SynchronizedRequestHandler.java Outdated Show resolved Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/communication/UidlRequestHandler.java Show resolved Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/SynchronizedRequestHandler.java Show resolved Hide resolved
@tepi tepi requested a review from mcollovati November 19, 2024 07:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tepi tepi merged commit 23093d7 into main Nov 19, 2024
26 checks passed
@tepi tepi deleted the fix/move-blocking-calls-outside-session-lock branch November 19, 2024 09:11
vaadin-bot pushed a commit that referenced this pull request Nov 19, 2024
@tepi @vaadin-bot
Fix: move blocking calls outside session lock (#19938) (#20475)
0a6e3c9 
Move blocking calls outside session lock (#19938)
@vaadin-bot
Copy link
Collaborator

Hi @tepi and @tepi, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 23093d7
error: could not apply 23093d7... Fix: move blocking calls outside session lock (#19938) (#20475)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mcollovati pushed a commit that referenced this pull request Nov 19, 2024
@vaadin-bot @tepi
fix: move blocking calls outside session lock (#19938) (#20475) (#20513)
3c49893 
Move blocking calls outside session lock (#19938)

Co-authored-by: Teppo Kurki <[email protected]>
tepi added a commit that referenced this pull request Nov 19, 2024
@tepi
Fix: move blocking calls outside session lock (#19938) (#20475)
1e67e56 
Move blocking calls outside session lock (#19938)
tepi added a commit that referenced this pull request Nov 19, 2024
@tepi
Fix: move blocking calls outside session lock (#19938) (#20475) (#20515)
8597ecf 
Move blocking calls outside session lock (#19938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.5 need to pick manually 24.4 target/24.4 target/24.5 +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tepi @vaadin-bot @mcollovati