Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flush logic (#20431) (CP: 24.5) #20443

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

Changes client side value binding logic so that if the user modifies the value during server round-trip, the value earlier sent to the server no longer overwrites user's changes once the round-trip finishes. Instead, user's changes are preserved. However, if the server-side value change handling logic actually changes the value and returns the new value to the client, that value will override any user input during round-trip.

Fixes #20365
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) November 11, 2024 15:37
Copy link

sonarcloud bot commented Nov 11, 2024

Copy link

Test Results

1 143 files  + 1  1 143 suites  +1   1h 26m 0s ⏱️ - 2m 43s
7 473 tests + 2  7 423 ✅ + 2  50 💤 ±0  0 ❌ ±0 
7 814 runs   - 17  7 756 ✅  - 16  58 💤  - 1  0 ❌ ±0 

Results for commit 8ccc3bd. ± Comparison against base commit b489b21.

@vaadin-bot vaadin-bot merged commit 98b8761 into 24.5 Nov 11, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20431-to-24.5-1731339093644 branch November 11, 2024 15:47
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants