feat: Add support for customizable projectFileExtensions #20397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
force-pushed
the
feat/19527-project-file-extensions
branch
from
fc9afca
to
27a0697
Compare
caalador
force-pushed
the
feat/19527-project-file-extensions
branch
from
27a0697
to
ab78bf8
Compare
9 tasks
tltv
requested changes
Nov 5, 2024
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinFlowPluginExtension.kt
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/InitParameters.java
Outdated
Show resolved
Hide resolved
caalador
force-pushed
the
feat/19527-project-file-extensions
branch
from
d4b4b8e
to
7fb996a
Compare
Fix initParam name, update javadocs
caalador
force-pushed
the
feat/19527-project-file-extensions
branch
from
7fb996a
to
af99ce3
Compare
mcollovati
reviewed
Nov 6, 2024
Comment on lines
125
to
126
| System.out.println( | ||
| "=== '" + options.getFrontendExtraFileExtensions() + "'"); |
There was a problem hiding this comment.
Suggested change
| System.out.println( | |
| "=== '" + options.getFrontendExtraFileExtensions() + "'"); | |
| System.out.println( | |
| "=== '" + options.getFrontendExtraFileExtensions() + "'"); |
There was a problem hiding this comment.
I forgot to push the removal =P
flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinFlowPluginExtension.kt
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskUpdateVite.java
Outdated
Show resolved
Hide resolved
fix gradle javadoc
|
Added input property for the gradle plugin. |
caalador
force-pushed
the
feat/19527-project-file-extensions
branch
from
37bb8b9
to
671380c
Compare
tltv
previously approved these changes
Nov 7, 2024
# Conflicts: # flow-plugins/flow-gradle-plugin/src/main/kotlin/com/vaadin/gradle/VaadinFlowPluginExtension.kt # flow-plugins/flow-maven-plugin/src/main/java/com/vaadin/flow/plugin/maven/FlowModeAbstractMojo.java # flow-plugins/flow-plugin-base/src/main/java/com/vaadin/flow/plugin/base/BuildFrontendUtil.java # flow-plugins/flow-plugin-base/src/main/java/com/vaadin/flow/plugin/base/PluginAdapterBase.java # flow-server/src/main/java/com/vaadin/flow/server/frontend/Options.java # flow-server/src/main/java/com/vaadin/flow/server/startup/AbstractConfigurationFactory.java # vaadin-dev-server/src/main/java/com/vaadin/base/devserver/startup/DevModeInitializer.java
|
tltv
approved these changes
Nov 8, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19527