Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make push work with strict CSP #20342

Merged
merged 6 commits into from
Oct 29, 2024
Merged

fix: make push work with strict CSP #20342

merged 6 commits into from
Oct 29, 2024

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Oct 25, 2024

Fixes #20329

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Test Results

1 142 files  ±0  1 142 suites  ±0   1h 28m 37s ⏱️ + 4m 13s
7 475 tests ±0  7 425 ✅ +1  50 💤 ±0  0 ❌ ±0 
7 811 runs   - 5  7 751 ✅  - 4  60 💤 ±0  0 ❌ ±0 

Results for commit 5678909. ± Comparison against base commit 0e70cb1.

♻️ This comment has been updated with latest results.

@tepi tepi marked this pull request as draft October 29, 2024 09:00
@tepi tepi marked this pull request as ready for review October 29, 2024 11:09
@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Oct 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tepi tepi mentioned this pull request Oct 29, 2024
Open
@mcollovati mcollovati merged commit 17be2d1 into main Oct 29, 2024
26 checks passed
@mcollovati mcollovati deleted the fix/make-push-work-with-strict-csp branch October 29, 2024 13:50
vaadin-bot pushed a commit that referenced this pull request Oct 29, 2024
@tepi @vaadin-bot
fix: make push work with strict CSP (#20342)
0657e15
vaadin-bot added a commit that referenced this pull request Oct 29, 2024
@vaadin-bot @tepi
fix: make push work with strict CSP (#20342) (#20381)
e80c756 
Co-authored-by: Teppo Kurki <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.5 prerelease version for Vaadin 24.6.0 Released with Vaadin 24.6.0.alpha2 target/24.5 +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to use Push with strict CSP mode
4 participants
@tepi @vaadin-bot @mcollovati @mshabarov