Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent possible error on embedded component disconnect #20260

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: prevent possible error on embedded component disconnect #20260

merged 1 commit into from
Oct 17, 2024

Conversation

web-padawan
Copy link
Member

Description

This fixes the following error which sometimes occurs when switching between docs pages with Java examples:

Uncaught TypeError: Cannot read properties of undefined (reading 'disconnected')
    at ContextMenuPresentationWc.disconnectedCallback (:8000/vaadin/VAADIN/generated/flow/web-components/context-menu-presentation-wc.js:131:18)
    at removeChild (chunk-UXDD7MME.js:8456:26)

I'm not sure how to test this but it makes sense to check for object being defined before calling its methods anyway.

Type of change

  • Bugfix

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Test Results

1 142 files  ± 0  1 142 suites  ±0   1h 25m 21s ⏱️ + 1m 29s
7 464 tests ± 0  7 414 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 797 runs  +17  7 737 ✅ +17  60 💤 ±0  0 ❌ ±0 

Results for commit 7405061. ± Comparison against base commit 1937249.

@mshabarov mshabarov added the Contribution PRs coming from the community or external to the team label Oct 16, 2024
@mshabarov
Copy link
Contributor

@web-padawan thanks for this fix, we can probably skip the test. Which versions do need this? I guess 24.4 and 24.5 as docs are running using them?

@mshabarov mshabarov merged commit f7f193a into main Oct 17, 2024
26 checks passed
@mshabarov mshabarov deleted the fix-embedded-disconnect branch October 17, 2024 06:15
vaadin-bot pushed a commit that referenced this pull request Oct 17, 2024
@web-padawan @vaadin-bot
fix: prevent possible error on embedded component disconnect (#20260)
9918835
vaadin-bot pushed a commit that referenced this pull request Oct 17, 2024
@web-padawan @vaadin-bot
fix: prevent possible error on embedded component disconnect (#20260)
f0fb924
vaadin-bot added a commit that referenced this pull request Oct 17, 2024
@vaadin-bot @web-padawan
fix: prevent possible error on embedded component disconnect (#20260) (…
835f6b6 
…#20272)

Co-authored-by: Serhii Kulykov <[email protected]>
mshabarov pushed a commit that referenced this pull request Oct 17, 2024
@vaadin-bot @web-padawan
fix: prevent possible error on embedded component disconnect (#20260) (…
c202a3c 
…#20273)

Co-authored-by: Serhii Kulykov <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha2 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.4 cherry-picked-24.5 Contribution PRs coming from the community or external to the team prerelease version for Vaadin 24.6.0 Released with Vaadin 24.6.0.alpha2 target/24.4 target/24.5 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @mshabarov @vaadin-bot