Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigatin to client view from server (#20151) (CP: 24.5) #20174

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

* fix: navigatin to client view from server

Navigation to the client view
using server navigate should
work normally and not try to
add layout for non layout
client view.

* remove class used for hilla compatibility
Copy link

sonarcloud bot commented Oct 8, 2024

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) October 8, 2024 06:17
Copy link

github-actions bot commented Oct 8, 2024

Test Results

1 141 files  ±0  1 141 suites  ±0   1h 8m 26s ⏱️ - 2m 22s
7 434 tests ±0  7 384 ✅ ±0  50 💤 ±0  0 ❌ ±0 
7 717 runs   - 7  7 659 ✅  - 5  58 💤  - 2  0 ❌ ±0 

Results for commit 3c1fbb5. ± Comparison against base commit 2ed1691.

@vaadin-bot vaadin-bot merged commit 99c0b5e into 24.5 Oct 8, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-20151-to-24.5-1728367672274 branch October 8, 2024 06:28
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.5.0.beta6 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants