Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add drag image for DragSource #20098

Merged
merged 6 commits into from
Oct 2, 2024
Merged

feat: add drag image for DragSource #20098

merged 6 commits into from
Oct 2, 2024

Conversation

tltv
Copy link
Member

@tltv tltv commented Sep 30, 2024

Adds DragSource#setDragImage(ComponentdragImage ) and DragSource#setDragImage(Component dragImage, int offsetX, int offsetY). API is used to set image component as a drag image for drag source component. Follows specification of HTML Drag and Drop API for DataTransfer#setDragImage() method.

Fixes: #6793

Adds `DragSource#setDragImage(ComponentdragImage )` and `DragSource#setDragImage(Component dragImage, int offsetX, int offsetY)`. API is used to set image component as a drag image for drag source component. Follows specification of HTML Drag and Drop API for DataTransfer#setDragImage() method.

Fixes: #6793
Copy link

github-actions bot commented Sep 30, 2024

Test Results

1 139 files  ±0  1 139 suites  ±0   1h 10m 35s ⏱️ +24s
7 414 tests +4  7 364 ✅ +4  50 💤 ±0  0 ❌ ±0 
7 777 runs   - 1  7 717 ✅  - 1  60 💤 ±0  0 ❌ ±0 

Results for commit 211ec8a. ± Comparison against base commit 623dae4.

♻️ This comment has been updated with latest results.

flow-dnd/pom.xml Outdated Show resolved Hide resolved
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Oct 2, 2024
Copy link

sonarcloud bot commented Oct 2, 2024

@mcollovati mcollovati merged commit 95db483 into main Oct 2, 2024
26 checks passed
@mcollovati mcollovati deleted the feat/6793-drag-image branch October 2, 2024 09:38
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha1 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom drag image for drag source
4 participants