fix: hide root output element #20040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that root output element added for React router in Flow.tsx doesn't accidentally change the main layout with CSS rules targeting it. Fixes: #19871
|
caalador
approved these changes
Sep 25, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Ensures that root output element added for React router in Flow.tsx doesn't accidentally change the main layout with CSS rules targeting it. Fixes: #19871
|
Hi @tltv and @caalador, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? |
vaadin-bot
added a commit
that referenced
this pull request
Sep 25, 2024
Ensures that root output element added for React router in Flow.tsx doesn't accidentally change the main layout with CSS rules targeting it. Fixes: #19871 Co-authored-by: Tomi Virtanen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that root output element added for React router in Flow.tsx doesn't accidentally change the main layout with CSS rules targeting it.
Fixes: #19871