feat: Report application URL when application is started #20027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in a couple of cases: 1. Browser launcher is not enabled 2. Browser launcher does not work 3. You closed the browser tab and a new one is not automatically reopened when you restart
If I set |
|
True, Spring never reports the URL to the dev server if the launch setting is off. Fixed now |
mcollovati
reviewed
Sep 24, 2024
vaadin-spring/src/main/java/com/vaadin/flow/spring/DevModeBrowserLauncher.java
Outdated
Show resolved
Hide resolved
mcollovati
approved these changes
Sep 24, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
This is useful in a couple of cases: 1. Browser launcher is not enabled 2. Browser launcher does not work 3. You closed the browser tab and a new one is not automatically reopened when you restart
mshabarov
pushed a commit
that referenced
this pull request
Sep 24, 2024
…0037) This is useful in a couple of cases: 1. Browser launcher is not enabled 2. Browser launcher does not work 3. You closed the browser tab and a new one is not automatically reopened when you restart Co-authored-by: Artur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in a couple of cases: