fix: React file not added when reactEnabled false #19845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add the outlet file if react is not enabled as the required react node files are not available. Fixes #19842
caalador
force-pushed
the
issues/19842-react-false
branch
from
8ff6389
to
1c0b56b
Compare
|
mshabarov
approved these changes
Aug 30, 2024
| @@ -579,7 +579,8 @@ public static boolean validateLicenses(PluginAdapterBase adapter) { | |||
| } | |||
|
|
|||
| FrontendDependenciesScanner scanner = new FrontendDependenciesScanner.FrontendDependenciesScannerFactory() | |||
| .createScanner(false, adapter.getClassFinder(), true, null); | |||
| .createScanner(false, adapter.getClassFinder(), true, null, | |||
There was a problem hiding this comment.
Thought about replacing two calls to adapter by just passing adapter object, but scanner probably shouldn't be coupled to adapter, as it can be called from context where it's not available.
|
This ticket/PR has been released with Vaadin 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add the outlet
file if react is not
enabled as the required
react node files are not
available.
Fixes #19842
Fixes vaadin/start#3159