-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: API for reloading current route target #19331
Conversation
Draft for now - just wanted to see existing tests pass fine with the change. Still needs tests to be added for the refresh functionality. |
Something to consider is |
My opinion is that the new API should recreate components even if the route is marked with |
Logic in this PR recreates the whole layout chain, which might not be wanted in all cases. Working on a change to provide means to control this in the API. |
flow-server/src/main/java/com/vaadin/flow/component/internal/UIInternals.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/router/internal/AbstractNavigationStateRenderer.java
Show resolved
Hide resolved
flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/RefreshCurrentRouteIT.java
Outdated
Show resolved
Hide resolved
flow-server/src/test/java/com/vaadin/flow/router/internal/NavigationStateRendererTest.java
Outdated
Show resolved
Hide resolved
...tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/RefreshCurrentRouteView.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/component/internal/UIInternals.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
* feat: API for reloading current route target * add tests * Add option to optionally refresh router layouts * Review fixes; Also handle PreserveOnRefresh routes * Review fixes * Unit tests for refresh
* feat: API for reloading current route target * add tests * Add option to optionally refresh router layouts * Review fixes; Also handle PreserveOnRefresh routes * Review fixes * Unit tests for refresh Co-authored-by: Teppo Kurki <[email protected]>
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
This ticket/PR has been released with Vaadin 24.4.0. |
Fixes #19244
Prepares implementation of #19262