Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Lazy annotation from Flow security beans #18463

Merged
merged 5 commits into from
Jan 22, 2024
Merged

fix: remove Lazy annotation from Flow security beans #18463

merged 5 commits into from
Jan 22, 2024

Commits on Jan 15, 2024

  1. fix: remove Lazy annotation from Flow security beans 

    For parameters with Lazy annotation, Spring generates a not-serializable proxy.
Since some security beans are used inside Flow listeners, they should be fully
serializable (or defined transient, if possible).
This change removes the unnecessary Lazy annotaions, moving the lazy evaluation
to VaadinWebSecurity.

Fixes #18458
    @mcollovati
    mcollovati committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0277d4b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into issues/18458_springautoconf_remove_lazy_para… 

    …meters
    @czp13
    czp13 authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    e619927 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Peter Czuczor <[email protected]>
    @mcollovati @czp13
    mcollovati and czp13 authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    539b63a View commit details
    Browse the repository at this point in the history

  2. set proxyBeanMethods to false

    @mcollovati
    mcollovati committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0c4b416 View commit details
    Browse the repository at this point in the history

  3. use try-with-resource for serialization/deserialization

    @mcollovati
    mcollovati committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    124c117 View commit details
    Browse the repository at this point in the history