-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate Label and add NativeLabel as replacement #16708
Conversation
flow-html-components/src/main/java/com/vaadin/flow/component/html/Label.java
Show resolved
Hide resolved
There are around 40 test classes in the flow repository alone where |
flow-html-components/src/main/java/com/vaadin/flow/component/html/Label.java
Outdated
Show resolved
Hide resolved
flow-html-components/src/main/java/com/vaadin/flow/component/html/Label.java
Outdated
Show resolved
Hide resolved
flow-html-components/src/main/java/com/vaadin/flow/component/html/Label.java
Outdated
Show resolved
Hide resolved
flow-html-components/src/main/java/com/vaadin/flow/component/html/Label.java
Outdated
Show resolved
Hide resolved
// devs. This should be dealt with by devs in development | ||
// mode. | ||
} | ||
checkForAttributeOnAttach = attachEvent.getUI() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that before adding a new listener by beforeClientResponse
, it should check
if (checkForAttributeOnAttach == null) {
otherwise I don't understand why we use beforeClientResponse
at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
The build validation stops because of compilation errors:
This pull request doesn't add/import this class, this is weird. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This ticket/PR has been released with Vaadin 24.1.0. |
@mshabarov I just realized that there are a lot of usages within the flow-components that are still using the old Label and polluting the logs because they are not associated on the server side, but on the client side thanks to the slot=label Attribute. I'm wondering if we should add this condition also to the list of valid usages to reduce the amount of work the component team has to do urgendly to remove the log spam for users. Example FormLayout or RadioGroup |
Description
Adds
NativeLabel
as direct replacement for the HTML-basedLabel
component / element.Fixes #4384
Fixes #3532
Type of change
Checklist
Additional for
Feature
type of change