-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add refresh flag to navigation event #15324
Conversation
Add the isRefreshEvent to BeforeEnterEvent and AfterNavigationEvent to be make it possible to diustinguish if the event is for a refresh of a preserve on refresh view. Fixes #14999
@@ -30,6 +30,7 @@ | |||
public class AfterNavigationEvent extends EventObject { | |||
|
|||
private final LocationChangeEvent event; | |||
private final boolean refreshEvent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding another type, could / should the NavigationTrigge be extended with a refresh enum and used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
262d8a2
to
2c9ffe2
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Add the isRefreshEvent to BeforeEnterEvent and AfterNavigationEvent to be make it possible to distinguish if the event is for a refresh of a preserve on refresh view. Fixes #14999
Add the isRefreshEvent to BeforeEnterEvent and AfterNavigationEvent to be make it possible to distinguish if the event is for a refresh of a preserve on refresh view. Fixes #14999
Hi @caalador and @mcollovati, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually? |
Add the isRefreshEvent to BeforeEnterEvent and AfterNavigationEvent to be make it possible to distinguish if the event is for a refresh of a preserve on refresh view. Fixes #14999
Add the isRefreshEvent to BeforeEnterEvent and AfterNavigationEvent to be make it possible to distinguish if the event is for a refresh of a preserve on refresh view. Fixes #14999 Co-authored-by: caalador <[email protected]>
Add the isRefreshEvent to BeforeEnterEvent and AfterNavigationEvent to be make it possible to distinguish if the event is for a refresh of a preserve on refresh view. Fixes #14999 Co-authored-by: caalador <[email protected]>
This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version. |
Add the isRefreshEvent to BeforeEnterEvent and AfterNavigationEvent to be make it possible to distinguish if the event is for a refresh of a preserve on refresh view. Fixes #14999
Add the isRefreshEvent to BeforeEnterEvent
and AfterNavigationEvent to be make it possible
to diustinguish if the event is for a refresh of
a preserve on refresh view.
Fixes #14999