-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adapt to a new auto configuration in Spring Boot #14629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support for auto configuration was removed in spring boot 3.0.0-M5.
mcollovati
added
the
Contribution
PRs coming from the community or external to the team
label
Sep 23, 2022
mcollovati
requested changes
Sep 23, 2022
...n/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
Outdated
Show resolved
Hide resolved
Thanks for the contribution |
mcollovati
previously approved these changes
Sep 23, 2022
Should this be done for master? |
MarcinVaadin
approved these changes
Sep 26, 2022
9 tasks
mshabarov
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also made a patch for master #14659
mshabarov
changed the title
Adapt to new auto configuration in spring boot. The spring.factories …
feat: Adapt to a new auto configuration in Spring Boot
Sep 27, 2022
Kudos, SonarCloud Quality Gate passed! |
mshabarov
added a commit
that referenced
this pull request
Sep 28, 2022
Spring Boot introduced a new location for auto configuration entries in spring boot 2.7.0. The new location is META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports. This has until spring boot 3.0.0-M5 worked in parallel with the spring.factories configuration. The spring.factories support was removed in spring boot 3.0.0-M5 so this move has to be done now in order for the auto configuration to be picked up. Fixes #14628 Picked to master from #14629 Co-authored-by: @aspan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spring Boot introduced a new location for auto configuration entries in spring boot 2.7.0. The new location is
META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports
. This has until spring boot 3.0.0-M5 worked in parallel with the spring.factories configuration.The spring.factories support was removed in spring boot 3.0.0-M5 so this move has to be done now in order for the auto configuration to be picked up.
Fixes #14628
Type of change
Checklist