fix: require Safari 14 minimum #13282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari 13 does not support the EventTarget constructor, used in @vaadin/components-base: https://caniuse.com/?search=EventTarget()
caalador
previously approved these changes
Mar 11, 2022
Artur-
reviewed
Mar 11, 2022
flow-server/src/main/java/com/vaadin/flow/shared/BrowserDetails.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Mar 14, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
Safari 13 does not support the EventTarget constructor, used in @vaadin/components-base: https://caniuse.com/?search=EventTarget()
joheriks
pushed a commit
that referenced
this pull request
Mar 14, 2022
Safari 13 does not support the EventTarget constructor, used in @vaadin/components-base: https://caniuse.com/?search=EventTarget() Co-authored-by: Johannes Eriksson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 13 does not support the EventTarget constructor,
used in @vaadin/components-base:
https://caniuse.com/?search=EventTarget()
Fixes #13271