Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unecessary jetty-maven-plugin scan configuration #13006

Merged
merged 1 commit into from
Feb 14, 2022
Merged

chore: remove unecessary jetty-maven-plugin scan configuration #13006

merged 1 commit into from
Feb 14, 2022

Conversation

mcollovati
Copy link
Collaborator

Description

jetty-maven-plugins is configured to scan changes in source directory,
but this is not necessary to trigger automatic reload becuase the test
compiles the source code into target/classes, that is already watched
by the plugin.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mcollovati
chore: remove unecessary jetty-maven-plugin scan configuration
0c30b4a 
jetty-maven-plugins is configured to scan changes in source directory,
but this is not necessary to trigger automatic reload becuase the test
compiles the source code into `target/classes`, that is already watched
by the plugin.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mcollovati mcollovati marked this pull request as ready for review February 11, 2022 21:15
@joheriks joheriks merged commit 2a1d1c0 into 2.8 Feb 14, 2022
@joheriks joheriks deleted the remove_unecessary_jetty_scan_config_2.8 branch February 14, 2022 11:59
vaadin-bot pushed a commit that referenced this pull request Feb 14, 2022
@mcollovati @vaadin-bot
chore: remove unecessary jetty-maven-plugin scan configuration (#13006)
b6e20a1 
jetty-maven-plugins is configured to scan changes in source directory,
but this is not necessary to trigger automatic reload becuase the test
compiles the source code into `target/classes`, that is already watched
by the plugin.
vaadin-bot added a commit that referenced this pull request Feb 14, 2022
@vaadin-bot @mcollovati
chore: remove unecessary jetty-maven-plugin scan configuration (#13006)…
4ce6fa7 
… (#13016)

jetty-maven-plugins is configured to scan changes in source directory,
but this is not necessary to trigger automatic reload becuase the test
compiles the source code into `target/classes`, that is already watched
by the plugin.

Co-authored-by: Marco Collovati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joheriks joheriks joheriks approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.7 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcollovati @joheriks @vaadin-bot