fix: cleanup url before resolving resource path in css-loader #13005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLs in CSS may contain a query string or fragment, that prevents a
correct resolution of resource real path and, consequently,
its inclusion in the output bundle. An example of this kind of url
are SVG Fragment Identifiers, such ones in fontawesome css:
`url("../webfonts/fa-solid-900.svg#fontawesome")`
When this URL is present on CSS file, the svg file will not be available
at runtime.
With this change, incoming URLs are cleaned up by removing potential
query string and fragment before resolving the real path against filesystem.
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Feb 15, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
URLs in CSS may contain a query string or fragment, that prevents a
correct resolution of resource real path and, consequently,
its inclusion in the output bundle. An example of this kind of url
are SVG Fragment Identifiers, such ones in fontawesome css:
`url("../webfonts/fa-solid-900.svg#fontawesome")`
When this URL is present on CSS file, the svg file will not be available
at runtime.
With this change, incoming URLs are cleaned up by removing potential
query string and fragment before resolving the real path against filesystem.
vaadin-bot
added a commit
that referenced
this pull request
Feb 15, 2022
#13031) URLs in CSS may contain a query string or fragment, that prevents a correct resolution of resource real path and, consequently, its inclusion in the output bundle. An example of this kind of url are SVG Fragment Identifiers, such ones in fontawesome css: `url("../webfonts/fa-solid-900.svg#fontawesome")` When this URL is present on CSS file, the svg file will not be available at runtime. With this change, incoming URLs are cleaned up by removing potential query string and fragment before resolving the real path against filesystem. Co-authored-by: Marco Collovati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
URLs in CSS may contain a query string or fragment, that prevents a
correct resolution of resource real path and, consequently,
its inclusion in the output bundle. An example of this kind of url
are SVG Fragment Identifiers, such ones in fontawesome css:
url("../webfonts/fa-solid-900.svg#fontawesome")When this URL is present on CSS file, the svg file will not be available
at runtime.
With this change, incoming URLs are cleaned up by removing potential
query string and fragment before resolving the real path against filesystem.
Type of change
Checklist
Additional for
Featuretype of change