test: Ensure file is closed after reading lines #12990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents.
caalador
requested changes
Feb 15, 2022
...est/java/com/vaadin/flow/testnpmonlyfeatures/performanceregression/StartupPerformanceIT.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Feb 16, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents.
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents.
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents.
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents.
vaadin-bot
added a commit
that referenced
this pull request
Feb 16, 2022
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents. Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Feb 16, 2022
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents. Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Feb 16, 2022
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents. Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Feb 16, 2022
Used a try-with-resources statement to ensure that log file gets closed after iterating over its contents. Co-authored-by: Marco Collovati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Used a try-with-resources statement to ensure that log file gets closed
after iterating over its contents.
Type of change
Checklist
Additional for
Featuretype of change