Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra log information for failing visitor #12910

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Feb 2, 2022

Add error log for when a class
visitor fails with an exception for
easier debugging.

Fixes #12759

Add error log for when a class
visitor fails with an exception for
easier debugging.

Fixes #12759
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

Unit Test Results

   773 files  ±0     773 suites  ±0   30m 14s ⏱️ -35s
5 769 tests ±0  5 721 ✔️ +1  48 💤 +1  0  - 1 
5 802 runs   - 2  5 753 ✔️  - 1  49 💤 +1  0  - 1 

Results for commit c154b0c. ± Comparison against base commit aa508e3.

@anssit anssit self-requested a review February 2, 2022 08:59
@anssit anssit merged commit 9933d81 into master Feb 2, 2022
@anssit anssit deleted the issues/12759-improve-exception-logging branch February 2, 2022 09:13
vaadin-bot pushed a commit that referenced this pull request Feb 2, 2022
Add error log for when a class
visitor fails with an exception for
easier debugging.

Fixes #12759
vaadin-bot pushed a commit that referenced this pull request Feb 2, 2022
Add error log for when a class
visitor fails with an exception for
easier debugging.

Fixes #12759
vaadin-bot pushed a commit that referenced this pull request Feb 2, 2022
Add error log for when a class
visitor fails with an exception for
easier debugging.

Fixes #12759
vaadin-bot added a commit that referenced this pull request Feb 2, 2022
Add error log for when a class
visitor fails with an exception for
easier debugging.

Fixes #12759

Co-authored-by: caalador <[email protected]>
vaadin-bot added a commit that referenced this pull request Feb 2, 2022
Add error log for when a class
visitor fails with an exception for
easier debugging.

Fixes #12759

Co-authored-by: caalador <[email protected]>
vaadin-bot added a commit that referenced this pull request Feb 2, 2022
Add error log for when a class
visitor fails with an exception for
easier debugging.

Fixes #12759

Co-authored-by: caalador <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exception logging to FrontendDependencies visitor
3 participants