fix: reliable deletion of node_modules #12822
Conversation
Set writable permission before deletion to handle symlinks properly.
|
This looks like a reversed approach i.e. fixing the issue after it has happened (files created without writable permission). What is causing the files to be created with the wrong permissions? |
Actually, setting write permission in the initial pass is an additional measure. It works without it also in my tests, but I added it as I am not sure if |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java
Outdated
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java
Outdated
Show resolved
Hide resolved
|
I will wing together a unit test that deletes a directory containing some internal symbolic links, though it may be hard to get it to actually fail with the previous impl as the file visiting order is non-deterministic. |
…spurious failures
…iles keep permission
|
Kudos, SonarCloud Quality Gate passed!
|
Do not set permissions nor follow symlinks when deleting node_modules. Fixes #12810
Do not set permissions nor follow symlinks when deleting node_modules. Fixes #12810 Co-authored-by: Johannes Eriksson <[email protected]>
|
This ticket/PR has been released with platform 23.0.0.alpha4 and is also targeting the upcoming stable 23.0.0 version. |
ZheSun88
added
cherry-picked-2.7
cherry-picked-2.8
and removed
need to pick manually 2.7
need to pick manually 2.8
labels
Do not set permissions nor follow symlinks when
deleting node_modules.
Fixes #12810