Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simpler condition when build fails #12535

Merged
merged 1 commit into from
Dec 8, 2021
Merged

chore: simpler condition when build fails #12535

merged 1 commit into from
Dec 8, 2021

Conversation

manolo
Copy link
Member

@manolo manolo commented Dec 8, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

Unit Test Results

   720 files     720 suites   22m 24s ⏱️
5 647 tests 5 597 ✔️ 50 💤 0 ❌
5 663 runs  5 613 ✔️ 50 💤 0 ❌

Results for commit 8fd5122.

♻️ This comment has been updated with latest results.

@manolo manolo merged commit b7c3b9f into master Dec 8, 2021
@manolo manolo deleted the simple-if branch December 8, 2021 11:51
manolo added a commit that referenced this pull request Dec 8, 2021
@manolo
chore: simpler condition when build fails (#12535)
bf7932a
@vaadin-bot
Copy link
Collaborator

Hi @manolo and @manolo, when i performed cherry-pick to this commit to 9.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick b7c3b9f
error: could not apply b7c3b9f... chore: simpler condition when build fails (#12535)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

manolo added a commit that referenced this pull request Dec 8, 2021
@manolo
chore: redistribute modules in CI actions (#12533 #12535) (CP: 9.0) (#…
75fa1a7 
…12537)

* chore: redistribute modules to avoid failures when running in the same folder (#12533) (CP: 9.0)

* chore: simpler condition when build fails (#12535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZheSun88 ZheSun88 ZheSun88 approved these changes

Assignees
No one assigned
Labels
cherry-picked-9.0 need to pick manually 9.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manolo @vaadin-bot @ZheSun88