Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace exec-maven-plugin with gradle-maven-plugin #12501

Merged
merged 1 commit into from
Dec 8, 2021
Merged

chore: replace exec-maven-plugin with gradle-maven-plugin #12501

merged 1 commit into from
Dec 8, 2021

Conversation

manolo
Copy link
Member

@manolo manolo commented Dec 2, 2021

This should fix problems when running the build in docker containers in windows.

@manolo manolo requested a review from ZheSun88 December 2, 2021 14:27
@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

Unit Test Results

   720 files     720 suites   22m 23s ⏱️
5 647 tests 5 597 ✔️ 50 💤 0 ❌
5 663 runs  5 613 ✔️ 50 💤 0 ❌

Results for commit c657f1d.

♻️ This comment has been updated with latest results.

ZheSun88
ZheSun88 reviewed Dec 3, 2021
View reviewed changes
flow-plugins/flow-gradle-plugin/pom.xml
<phase>prepare-package</phase>
<configuration>
<executable>${gradle.executable}</executable>
Copy link
Contributor

@ZheSun88 ZheSun88 Dec 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gradle.executable property can be removed from pom file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ZheSun88
Copy link
Contributor

ZheSun88 commented Dec 3, 2021 •
edited
Loading

this fix runs good on windows..(but it failed here with the flow validation/it-tests(6,3) )

it passes the flow compile and install, but failed with the step on upload-artifacts.

image

idation/build]   | With the provided path, there will be 1 file uploaded
[Flow Validation/build]   💬  ::debug::Root artifact directory is /mnt/c/temp/flow
[Flow Validation/build]   ❗  ::error::Unable to get ACTIONS_RUNTIME_TOKEN env variable
[Flow Validation/build]   ❌  Failure - actions/upload-artifact@v2

ZheSun88
ZheSun88 previously approved these changes Dec 3, 2021
View reviewed changes
@manolo manolo force-pushed the gradle-replace-exec branch 4 times, most recently from d82ffff to f0d3230 Compare December 8, 2021 07:55
@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Dec 8, 2021
@manolo manolo force-pushed the gradle-replace-exec branch 2 times, most recently from 48b7555 to c4b2c32 Compare December 8, 2021 10:39
@manolo manolo force-pushed the gradle-replace-exec branch from c4b2c32 to c657f1d Compare December 8, 2021 10:39
ZheSun88
ZheSun88 approved these changes Dec 8, 2021
View reviewed changes
.github/workflows/validation.yml Outdated
run: |
type java && java -version
type mvn && mvn -version
type node && node -version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe node -v work

@vaadin-bot vaadin-bot added +0.0.1 and removed +0.1.0 labels Dec 8, 2021
@manolo manolo marked this pull request as ready for review December 8, 2021 11:01
@manolo manolo merged commit 2ecff67 into master Dec 8, 2021
@manolo manolo deleted the gradle-replace-exec branch December 8, 2021 11:01
ZheSun88 pushed a commit that referenced this pull request Dec 9, 2021
@manolo @ZheSun88
chore: replace exec-maven-plugin with gradle-maven-plugin (#12501)
d88ce22
manolo added a commit that referenced this pull request Dec 9, 2021
@vaadin-bot @manolo
chore: replace exec-maven-plugin with gradle-maven-plugin (#12501) (#…
193d65b 
…12545)

Co-authored-by: Manuel Carrasco Moñino <[email protected]>
manolo added a commit that referenced this pull request Dec 10, 2021
@manolo
Revert "chore: replace exec-maven-plugin with gradle-maven-plugin (#1…
462f828 
…2501)"

This reverts commit 2ecff67.
caalador pushed a commit that referenced this pull request Dec 10, 2021
@manolo
Revert "chore: replace exec-maven-plugin with gradle-maven-plugin (#1…
66c589e 
…2501)" (#12551)

This reverts commit 2ecff67.
caalador added a commit that referenced this pull request Dec 10, 2021
@caalador
Revert "chore: replace exec-maven-plugin with gradle-maven-plugin (#1…
fc9f62a 
…2501) (#12545)"

This reverts commit 193d65b.
caalador added a commit that referenced this pull request Dec 10, 2021
@caalador
Revert "chore: replace exec-maven-plugin with gradle-maven-plugin (#1…
cf8c21a 
…2501) (#12545)" (#12552)

This reverts commit 193d65b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZheSun88 ZheSun88 ZheSun88 approved these changes

Assignees
No one assigned
Labels
cherry-picked-9.0 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manolo @ZheSun88 @vaadin-bot