Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix faulty given path for webpackOutput #12122

Merged
merged 2 commits into from
Oct 25, 2021
Merged

fix: Fix faulty given path for webpackOutput #12122

merged 2 commits into from
Oct 25, 2021

Conversation

caalador
Copy link
Contributor

Fixes #12117

@caalador caalador requested a review from mshabarov October 25, 2021 05:32
mshabarov
mshabarov requested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is needed. Without a test, I cannot say whether this change would fix the issue with image resources used from Java.

@caalador
Copy link
Contributor Author

Added test to validate path to be correct.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  1. MAJOR DevModeInitializer.java#L449: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. rule

@mshabarov mshabarov enabled auto-merge (squash) October 25, 2021 07:31
@mshabarov mshabarov merged commit c283395 into 2.7 Oct 25, 2021
@mshabarov mshabarov deleted the issues/12117_fix_faulty_path branch October 25, 2021 07:37
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
Released with Platform 14.7.4 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caalador @vaadin-bot @mshabarov