Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: bump Jsoup version #12046

Merged
merged 2 commits into from
Oct 18, 2021
Merged

fix!: bump Jsoup version #12046

merged 2 commits into from
Oct 18, 2021

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Oct 15, 2021

This fix introduces a potential backward incompatibility for the users who uses JSoup dependency explicitly in their code.For such users either the JSoup dependency in their project should be declared explicitly (with an older version) or the code needs to be updated to use new JSoup API.

fixes si#41

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

This fix introduces a potential backward incompatibility for the users who uses JSoup dependency explicitly in their code.For such users either the JSoup dependency in their project should be declared explicitly (with an older version) or the code needs to be updated to use new JSoup API.

fixes si #41
@denis-anisimov denis-anisimov changed the base branch from master to 8.0 October 15, 2021 08:29
@denis-anisimov
Copy link
Contributor Author

This is backward incompatible change which should go to all previous versions: 2.7, 1.0 since it fixes a security issue found in JSoup.

@Legioth
Copy link
Member

Legioth commented Oct 18, 2021

LGTM, but I always insist that someone from the development team does the final approval.

@denis-anisimov
Copy link
Contributor Author

Sure, very good point.

@mshabarov mshabarov merged commit cb1aeb0 into 8.0 Oct 18, 2021
@mshabarov mshabarov deleted the 41-si-upgrade-jsoup-version branch October 18, 2021 10:11
@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov and @mshabarov, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick cb1aeb0
error: could not apply cb1aeb0... fix!: bump Jsoup version (#12046)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov and @mshabarov, when i performed cherry-pick to this commit to 1.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick cb1aeb0
error: could not apply cb1aeb0... fix!: bump Jsoup version (#12046)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

denis-anisimov pushed a commit that referenced this pull request Oct 19, 2021
This fix introduces a potential backward incompatibility for the users who uses JSoup dependency explicitly in their code.For such users either the JSoup dependency in their project should be declared explicitly (with an older version) or the code needs to be updated to use new JSoup API.
mshabarov pushed a commit that referenced this pull request Oct 25, 2021
This fix introduces a potential backward incompatibility for the users who uses JSoup dependency explicitly in their code.For such users either the JSoup dependency in their project should be declared explicitly (with an older version) or the code needs to be updated to use new JSoup API.
denis-anisimov pushed a commit that referenced this pull request Oct 25, 2021
This fix introduces a potential backward incompatibility for the users who uses JSoup dependency explicitly in their code.For such users either the JSoup dependency in their project should be declared explicitly (with an older version) or the code needs to be updated to use new JSoup API.
mshabarov pushed a commit that referenced this pull request Oct 25, 2021
This fix introduces a potential backward incompatibility for the users who uses JSoup dependency explicitly in their code.For such users either the JSoup dependency in their project should be declared explicitly (with an older version) or the code needs to be updated to use new JSoup API.
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 21.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants