fix: show the accurate route class name in err msg #12045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-anisimov
approved these changes
Oct 15, 2021
caalador
pushed a commit
that referenced
this pull request
Oct 26, 2021
* fix: show the acurate route class name in err msg * code format
caalador
added a commit
that referenced
this pull request
Oct 26, 2021
* fix: show the acurate route class name in err msg * code format Co-authored-by: Haijian Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
navigationTargetis already a Class, should callnavigationTarget.getName()directly, callingnavigationTarget.getClass().getName()will always givejava.lang.Classwhich is not helpful in the error message.