-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set style property priority using proper API method #12019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pleku the way how the important
rule is identified in the input value string looks for me a bit tricky, but I don't know a better solution. The main idea behind, I believe, is to verify that the passed input contains a proper rule by parsing it through the test element and check the result of element.getStyle().getPropertyPriority(name)
. Unit tests and usage test are in place.
I'm not sure the line 754 is needed, but otherwise LGTM.
flow-client/src/main/java/com/vaadin/client/flow/binding/SimpleElementBindingStrategy.java
Outdated
Show resolved
Hide resolved
Denis Anisimov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
SonarQube analysis reported 2 issues
|
fixes #11981 Co-authored-by: Denis Anisimov <[email protected]> Co-authored-by: Pekka Hyvönen <[email protected]>
fixes #11981 Co-authored-by: Denis Anisimov <[email protected]> Co-authored-by: Pekka Hyvönen <[email protected]>
…2269) fixes #11981 Co-authored-by: Denis Anisimov <[email protected]> Co-authored-by: Pekka Hyvönen <[email protected]> Co-authored-by: Denis <[email protected]> Co-authored-by: Denis Anisimov <[email protected]> Co-authored-by: Pekka Hyvönen <[email protected]>
…2268) fixes #11981 Co-authored-by: Denis Anisimov <[email protected]> Co-authored-by: Pekka Hyvönen <[email protected]> Co-authored-by: Denis <[email protected]> Co-authored-by: Denis Anisimov <[email protected]> Co-authored-by: Pekka Hyvönen <[email protected]>
This ticket/PR has been released with platform 22.0.0.beta2 and is also targeting the upcoming stable 22.0.0 version. |
fixes #11981
Description
Please list all relevant dependencies in this section and provide summary of the change, motivation and context.
Fixes # (issue)
Type of change
Checklist
Additional for
Feature
type of change