Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return immidiately if VaadinSession is not initialized (#11974) (#11986) (CP: 7.0) #11988

Merged
merged 1 commit into from
Oct 6, 2021
Merged

fix: return immidiately if VaadinSession is not initialized (#11974) (#11986) (CP: 7.0) #11988

merged 1 commit into from
Oct 6, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 2 issues

  1. MAJOR VaadinSession.java#L217: This block of commented-out lines of code should be removed. rule
  2. INFO VaadinSession.java#L78: Do not forget to remove this deprecated code someday. rule

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 98846f4 into 7.0 Oct 6, 2021
@vaadin-bot
Copy link
Collaborator Author

This PR has been merged with 'squash' method.[Message is sent from bot]

@vaadin-bot vaadin-bot deleted the cherry-pick-11986-to-7.0-1633511543633 branch October 6, 2021 10:00
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 20.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
Released with Platform 20.0.8 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaadin-bot @vaadin-review-bot